Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds Cis2Client #304

Merged
merged 13 commits into from
Aug 10, 2023
Merged

Adds Cis2Client #304

merged 13 commits into from
Aug 10, 2023

Conversation

parv0888
Copy link
Contributor

Purpose

Adds Cis2 Client to address #295

Changes

Adds Cis2 Client to address #295

Checklist

  • My code follows the style of this project.
  • The code compiles without warnings.
  • I have performed a self-review of the changes.
  • I have documented my code, in particular the intent of the
    hard-to-understand areas.
  • (If necessary) I have updated the CHANGELOG.

CLA acceptance

By submitting the contribution I accept the terms and conditions of the
Contributor License Agreement v1.0

@parv0888 parv0888 changed the title added cis2 client Adds Cis2Client Jun 20, 2023
This was referenced Jun 20, 2023
Closed
Merged
@abizjak abizjak self-requested a review June 20, 2023 07:49
@abizjak abizjak requested a review from limemloh July 4, 2023 09:00
limemloh
limemloh requested changes Jul 4, 2023
View reviewed changes
Copy link
Collaborator

@limemloh limemloh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall good!
Have some comments and some suggestions for you to look at

concordium-cis2/CHANGELOG.md Outdated Show resolved Hide resolved
concordium-cis2/CHANGELOG.md Outdated Show resolved Hide resolved
concordium-cis2/Cargo.toml Outdated Show resolved Hide resolved
concordium-cis2/src/cis2_client.rs Outdated Show resolved Hide resolved
concordium-cis2/src/cis2_client.rs Outdated Show resolved Hide resolved
concordium-cis2/src/cis2_client.rs Outdated Show resolved Hide resolved
concordium-cis2/src/cis2_client.rs Outdated Show resolved Hide resolved
concordium-cis2/src/cis2_client.rs Outdated Show resolved Hide resolved
concordium-cis2/src/cis2_client.rs Show resolved Hide resolved
concordium-cis2/src/cis2_client.rs Show resolved Hide resolved
@parv0888 parv0888 requested a review from limemloh July 25, 2023 23:01
limemloh
limemloh requested changes Aug 7, 2023
View reviewed changes
Copy link
Collaborator

@limemloh limemloh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!
Only a few minor comments from me for this to be merged.

concordium-cis2/src/cis2_client.rs Outdated Show resolved Hide resolved
concordium-cis2/src/cis2_client.rs Outdated Show resolved Hide resolved
concordium-cis2/src/cis2_client.rs Outdated Show resolved Hide resolved
concordium-cis2/src/cis2_client.rs Outdated Show resolved Hide resolved
@parv0888 parv0888 requested a review from limemloh August 7, 2023 23:02
abizjak
abizjak reviewed Aug 9, 2023
View reviewed changes
concordium-cis2/src/cis2_client.rs Outdated Show resolved Hide resolved
concordium-cis2/src/cis2_client.rs Outdated Show resolved Hide resolved
concordium-cis2/src/cis2_client.rs Outdated Show resolved Hide resolved
concordium-cis2/src/cis2_client.rs Outdated Show resolved Hide resolved
concordium-cis2/src/cis2_client.rs Outdated Show resolved Hide resolved
concordium-cis2/src/cis2_client.rs Outdated Show resolved Hide resolved
concordium-cis2/src/cis2_client.rs Outdated Show resolved Hide resolved
concordium-cis2/src/lib.rs Outdated Show resolved Hide resolved
abizjak
abizjak approved these changes Aug 10, 2023
View reviewed changes
concordium-cis2/src/cis2_client.rs Outdated Show resolved Hide resolved
concordium-cis2/src/cis2_client.rs Outdated Show resolved Hide resolved
concordium-cis2/src/cis2_client.rs Outdated Show resolved Hide resolved
concordium-cis2/src/cis2_client.rs Outdated Show resolved Hide resolved
concordium-cis2/src/cis2_client.rs Outdated Show resolved Hide resolved
concordium-cis2/src/cis2_client.rs Outdated Show resolved Hide resolved
concordium-cis2/src/cis2_client.rs Outdated Show resolved Hide resolved
@abizjak
Copy link
Contributor

abizjak commented Aug 10, 2023

@parv0888 some imports need to be adjusted. Looks good otherwise.

parv0888
parv0888 commented Aug 10, 2023
View reviewed changes
concordium-cis2/src/lib.rs Outdated Show resolved Hide resolved
@parv0888 parv0888 requested a review from abizjak August 10, 2023 12:09
@abizjak abizjak merged commit eb13c51 into Concordium:main Aug 10, 2023
126 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abizjak abizjak abizjak approved these changes

@limemloh limemloh limemloh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@parv0888 @abizjak @limemloh