Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix windows ledger connection issue #358

Merged
merged 5 commits into from
Mar 7, 2024
Merged

Fix windows ledger connection issue #358

merged 5 commits into from
Mar 7, 2024

Conversation

orhoj
Copy link
Contributor

@orhoj orhoj commented Feb 28, 2024

Purpose

Fix a Ledger connectivity issue experienced on Windows.

Changes

  • Add a USB detach event listener where we check if the Ledger is actually still connected.

Checklist

  • My code follows the style of this project.
  • The code compiles without warnings.
  • I have performed a self-review of the changes.
  • I have documented my code, in particular the intent of the
    hard-to-understand areas.
  • (If necessary) I have updated the CHANGELOG.

shjortConcordium
shjortConcordium approved these changes Mar 4, 2024
View reviewed changes
app/preload/ledger/ledgerObserverImpl.ts Outdated Show resolved Hide resolved
app/preload/ledger/ledgerObserverImpl.ts Show resolved Hide resolved
@orhoj orhoj merged commit 3f57f0e into main Mar 7, 2024
4 checks passed
@orhoj orhoj deleted the fix-windows-ledger-connection-issue branch March 7, 2024 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shjortConcordium shjortConcordium shjortConcordium approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@orhoj @shjortConcordium