Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial template #100

Merged
merged 27 commits into from
Sep 23, 2024
Merged

Initial template #100

merged 27 commits into from
Sep 23, 2024

Conversation

DOBEN
Copy link
Member

@DOBEN DOBEN commented Sep 2, 2024 •
edited
Loading

Purpose

Addresses #96

Next PR:

  • Apply Figma UI design.

Changes

Initial compliance-reward-distribution-dapp front-end.

@DOBEN DOBEN force-pushed the frontend-compliance-reward-distribution-dapp branch from 3e130ee to 9601f50 Compare September 16, 2024 08:06
Victor-N-Suadicani
Victor-N-Suadicani approved these changes Sep 16, 2024
View reviewed changes
Copy link

@Victor-N-Suadicani Victor-N-Suadicani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only checked the Rust part.

compliant-reward-distribution/indexer-and-server/src/bin/server.rs Outdated Show resolved Hide resolved
compliant-reward-distribution/indexer-and-server/src/bin/server.rs Outdated Show resolved Hide resolved
soerenbf
soerenbf reviewed Sep 18, 2024
View reviewed changes
compliant-reward-distribution/frontend/yarn.lock Outdated Show resolved Hide resolved
compliant-reward-distribution/frontend/src/apiReqeuests.ts Outdated Show resolved Hide resolved
compliant-reward-distribution/frontend/src/apiReqeuests.ts Outdated Show resolved Hide resolved
compliant-reward-distribution/frontend/src/apiReqeuests.ts Show resolved Hide resolved
compliant-reward-distribution/frontend/src/components/ConnectWallet.tsx Show resolved Hide resolved
compliant-reward-distribution/frontend/src/components/ZkProofSubmission.tsx Outdated Show resolved Hide resolved
compliant-reward-distribution/frontend/src/components/TweetSubmission.tsx Outdated Show resolved Hide resolved
compliant-reward-distribution/frontend/src/utils.ts Outdated Show resolved Hide resolved
compliant-reward-distribution/frontend/src/wallet-connection.tsx Show resolved Hide resolved
compliant-reward-distribution/indexer-and-server/src/bin/server.rs Show resolved Hide resolved
@DOBEN DOBEN force-pushed the frontend-compliance-reward-distribution-dapp branch from c83908f to 0b498fe Compare September 19, 2024 13:08
@DOBEN DOBEN force-pushed the frontend-compliance-reward-distribution-dapp branch from 7634e1c to 84e88a5 Compare September 20, 2024 07:17
soerenbf
soerenbf reviewed Sep 20, 2024
View reviewed changes
Copy link
Contributor

@soerenbf soerenbf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are some things I think makes sense to change. Mostly minor stuff, but an annoying one is the account change/disconnect not propagating to the application. Would also be nice if admin page was hidden for regular users.

Otherwise it looks good 🥇

compliant-reward-distribution/frontend/src/wallet-connection.tsx Outdated Show resolved Hide resolved
compliant-reward-distribution/frontend/src/utils.ts Outdated Show resolved Hide resolved
compliant-reward-distribution/frontend/src/wallet-connection.tsx Outdated Show resolved Hide resolved
compliant-reward-distribution/frontend/src/apiReqeuests.ts Outdated Show resolved Hide resolved
compliant-reward-distribution/frontend/src/apiReqeuests.ts Outdated Show resolved Hide resolved
compliant-reward-distribution/frontend/src/components/Admin/AdminGetAccountData.tsx Outdated Show resolved Hide resolved
compliant-reward-distribution/frontend/src/components/Admin/AdminGetPendingApprovals.tsx Outdated Show resolved Hide resolved
compliant-reward-distribution/frontend/src/apiReqeuests.ts Outdated Show resolved Hide resolved
compliant-reward-distribution/frontend/src/wallet-connection.tsx Show resolved Hide resolved
compliant-reward-distribution/frontend/src/App.tsx Outdated Show resolved Hide resolved
soerenbf
soerenbf approved these changes Sep 23, 2024
View reviewed changes
Copy link
Contributor

@soerenbf soerenbf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 💯

@DOBEN DOBEN merged commit f23b8a1 into main Sep 23, 2024
67 checks passed
@DOBEN DOBEN deleted the frontend-compliance-reward-distribution-dapp branch September 23, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Victor-N-Suadicani Victor-N-Suadicani Victor-N-Suadicani approved these changes

@soerenbf soerenbf soerenbf approved these changes

@limemloh limemloh Awaiting requested review from limemloh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DOBEN @soerenbf @Victor-N-Suadicani