Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecation fix: use new SCSS syntax #2088

Open
wants to merge 1 commit into
base: stable
Choose a base branch
from

Conversation

mattheworiordan
Copy link

@mattheworiordan mattheworiordan commented Jun 8, 2016

This change fixes the deprecation warning with SASS and fixes issue #2052.

Note, until this PR is merged in, if it ever will be (there are currently 45 open PRs), you can use it simply in your Rails projects by adding the following to your Gemfile:

git 'https://github.com/ably-forks/compass', branch: 'sass-deprecation-warning-fix' do
  gem 'compass-core'
end

The warning this PR fixes is:

DEPRECATION WARNING on line 92 of /Users/mattheworiordan/.rvm/gems/ruby-2.2.2/gems/compass-core-1.0.3/stylesheets/compass/css3/_deprecated-support.scss: #{} interpolation near operators will be simplified
in a future version of Sass. To preserve the current behavior, use quotes:

  unquote('"$ie6-"#{$legacy-support-for-ie6} "$ie7-"#{$legacy-support-for-ie7} "$ie8-"#{$legacy-support-for-ie8}')

Fixes deprecation warning with SASS and Compass#2052

```
DEPRECATION WARNING on line 92 of /Users/mattheworiordan/.rvm/gems/ruby-2.2.2/gems/compass-core-1.0.3/stylesheets/compass/css3/_deprecated-support.scss: #{} interpolation near operators will be simplified
in a future version of Sass. To preserve the current behavior, use quotes:

  unquote('"$ie6-"#{$legacy-support-for-ie6} "$ie7-"#{$legacy-support-for-ie7} "$ie8-"#{$legacy-support-for-ie8}')
```
@nsgc
Copy link

nsgc commented Feb 3, 2017

Hi @scottdavis, Thanks for maintenance.
I also want this patch.

@julkue
Copy link

julkue commented Mar 1, 2017

Why isn't this merged yet?

@dmitry-solomadin
Copy link

@julmot because opensource :)

aCandidMind referenced this pull request May 24, 2017
Updated README to inform users Compass is no longer supported.
@aCandidMind
Copy link

Just as a note: PR #2094 is a clear indication that compass is no longer supported. I tried to point people in other directions with PR #2124 (e.g. using thoughtbot/bourbon).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants