Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified default value of http_generated_images_dir to fall back to generated_images_dir instead of http_images_dir. #2035

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

paulmer
Copy link

@paulmer paulmer commented Dec 10, 2015

The documentation indicates that http_generated_images_path if unset should default to http_path + generated_images_dir. The current behavior, however, is for http_generated_images_path to default to http_images_path. If generated_images_dir is changed, http_generated_images_path does not change. This patch changes the default value of http_generated_images_dir to correspond with the documentation.

Existing configurations that rely on changes to http_images_path to affect the default value of http_generated_images_path are incompatible with this change, however, it is more useful to maintain the logical correspondence between http_generated_images_path and generated_images_dir, which is specified by the current documentation.

generated_images_dir instead of http_images_dir.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant