initial waterfall backend #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adds route `/gitcommitsummary` to be the backend of the ci-dashboard waterfall
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds route
/gitcommitsummaryto be the backend of the ci-dashboard waterfallThis isn't particularly optimal. at all. but it's a start! towards moving the impl off the frontend and into the backend. Ideally it should precompute this summary data and store in database. For initial impl it just computes on the fly.
Limitation I'm hitting is
GetGitcommitseems to supply timestamps properly, butGetGitcommitsummaryis giving me0001-01-01T00:00:00Zwhich ain't right. I'm not sure why, main difference here isGetGitcommithas a special custom translation layer that does all sorts of special wonk, whereas forGetGitcommitsummaryI just let it pass the data through directly, which as far as I can tell should just work? Regardless,commit.Edges.Gitcommit.Timestampitself appears to be wrong from some debugging, so I'm not sure why that's happening