Add no deps param for install for manager-core #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yoland68
force-pushed
the
yo-no-deps-uv-install
branch
from
5348f81
to
eae6435
Compare
yoland68
changed the title
|
|
||
| assert result is None | ||
| assert error_occurred is True | ||
| assert "[ComfyUI-Manager] Failed to execute the command 'python -m comfy_cli dependency'." in captured_output.getvalue() |
There was a problem hiding this comment.
nl@eof in these files
ltdrdata
reviewed
Sep 21, 2024
glob/manager_server.py
Outdated
| @@ -967,6 +972,7 @@ def sanitize(data): | |||
|
|
|||
|
|
|||
| async def _confirm_try_install(sender, custom_node_url, msg): | |||
| import pdb; pdb.set_trace() | |||
There was a problem hiding this comment.
lol, my bad, PR s def not ready
yoland68
force-pushed
the
yo-no-deps-uv-install
branch
from
72abf23
to
147b51a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.