forked from comfyanonymous/litegraph.js
-
Notifications
You must be signed in to change notification settings - Fork 10
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Clock prompt dialog input on canvas click (#80)
- Loading branch information
1 parent
86d9391
commit f351b1d
Showing
1 changed file
with
9 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f351b1d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a new bug with this code. Clicking input on the node will bring up a dialog, but releasing the mouse will automatically close the dialog.
f351b1d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
on touch device? Should maybe use
mouseup
event, or increase the timeout.f351b1d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since I can't reproduce it, it's hard to test a fix. Can you try increasing the timeout here to something like
256
and see if it fixes it?litegraph.js/src/litegraph.js
Line 11444 in 3387e16
Otherwise you can tell me the device and browser app and I can try to reproduce that way.
f351b1d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm using google browser for windows, increase the timeout is ok, thanks
f351b1d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for bringing it up. It seems to only happen on STRING inputs. I just pushed a fix for it: #86