Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed patch that forced numpy<2 on windows #179

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

telamonian
Copy link
Member

now that pytorch has updated beyond the broken 2.4 release, we can now remove the patch that forced numpy<2 on windows. We should test this on windows first before pulling this in

@ltdrdata
Copy link
Member

ltdrdata commented Sep 14, 2024

This requires some caution. It's not just an issue with torch; there are cases where other dependency packages frequently used in custom nodes can cause serious problems, so testing is necessary.

If I remember correctly, numba was also one of the packages that caused problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants