Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI refactoring (WIP) #1043

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

UI refactoring (WIP) #1043

wants to merge 1 commit into from
+124 −185

Conversation

dmx974
Copy link
Contributor

@dmx974 dmx974 commented Sep 29, 2024

  • move TopMenubar to LayoutDefault
  • simplify SideToolbar and move it to LayoutDefault
  • properly integrate canvas creation into vue rendering (instead of creating a DOM-dirty graph-canvas-container)
  • refactor to be able to remove all unnecessary tag (it ruins HMR during development)
  • start cleaning app.ts to remove $(el) for TopMenubar, SideToolbar and Canvas

huchenlei
huchenlei requested changes Sep 30, 2024
View reviewed changes
Copy link
Member

@huchenlei huchenlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please consider split the PR into 5 individual PRs that each does single task. It would make debugging and reviewing much easier.

@robinjhuang
Copy link
Member

@dmx974 Is this still WIP?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huchenlei huchenlei huchenlei requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dmx974 @robinjhuang @huchenlei