Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: render jpc-numbers in documentation #274

Merged
merged 17 commits into from
Jul 19, 2024
Merged

DOC: render jpc-numbers in documentation #274

merged 17 commits into from
Jul 19, 2024

Conversation

grayson-helmholz
Copy link
Contributor

@grayson-helmholz grayson-helmholz commented Jul 1, 2024

Closes #273

Tip

See preview here.

@grayson-helmholz grayson-helmholz added the 📝 Docs Improvements or additions to documentation label Jul 1, 2024
@grayson-helmholz grayson-helmholz self-assigned this Jul 1, 2024
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@grayson-helmholz grayson-helmholz changed the title Render jpc DOC: Render jpc Jul 1, 2024
@grayson-helmholz grayson-helmholz changed the title DOC: Render jpc DOC: render jpc-numbers in documentation Jul 1, 2024
src/qrules/io/_dot.py Outdated Show resolved Hide resolved
src/qrules/io/_dot.py Outdated Show resolved Hide resolved
docs/usage/visualize.ipynb Outdated Show resolved Hide resolved
src/qrules/io/_dot.py Outdated Show resolved Hide resolved
docs/usage/visualize.ipynb Outdated Show resolved Hide resolved
@redeboer
Copy link
Member

redeboer commented Jul 8, 2024

Seems that the rendering is not yet working (see preview
b18dac822a1f8afb91fa5380c49a51447d0511ac4032bedee6e001d8cf9594aa

.gitignore Show resolved Hide resolved
src/qrules/io/_dot.py Outdated Show resolved Hide resolved
docs/usage/visualize.ipynb Outdated Show resolved Hide resolved
docs/usage/visualize.ipynb Outdated Show resolved Hide resolved
Copy link
Member

@redeboer redeboer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, almost there 🎉

docs/usage/reaction.ipynb Outdated Show resolved Hide resolved
src/qrules/io/_dot.py Outdated Show resolved Hide resolved
src/qrules/io/_dot.py Show resolved Hide resolved
src/qrules/io/_dot.py Outdated Show resolved Hide resolved
@redeboer redeboer marked this pull request as ready for review July 19, 2024 10:34
Copy link
Member

@redeboer redeboer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, well done 🎉

@grayson-helmholz grayson-helmholz merged commit fe32040 into main Jul 19, 2024
19 checks passed
@grayson-helmholz grayson-helmholz deleted the render-jpc branch July 19, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📝 Docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Render state transition solutions as J^PC(I^G)
2 participants