Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow setting custom topologies in STM #103

Merged
merged 2 commits into from
Sep 24, 2021
Merged

Conversation

redeboer
Copy link
Member

Closes #96

Made the StateTransitionManager.topologies attribute public, so that it's easier to feed custom topologies to the StateTransitionManager. Note that the topologies attribute is immutable and can only be modified by overwriting it, so I decided to avoid cluttering the code with additional setters and getters.

An example for 2-to-2 topologies (see also #29) is illustrated in a new notebook.

@redeboer redeboer added 📝 Docs Improvements or additions to documentation ✨ Feature New feature added to the package labels Sep 24, 2021
@redeboer redeboer added this to the 0.9.2 milestone Sep 24, 2021
@redeboer redeboer self-assigned this Sep 24, 2021
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@redeboer redeboer enabled auto-merge (squash) September 24, 2021 11:10
@codecov
Copy link

codecov bot commented Sep 24, 2021

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 93.41%. Comparing base (0de579a) to head (0b7544f).
Report is 143 commits behind head on main.

Files Patch % Lines
src/qrules/transition.py 75.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #103   +/-   ##
=======================================
  Coverage   93.41%   93.41%           
=======================================
  Files          15       15           
  Lines        3160     3161    +1     
=======================================
+ Hits         2952     2953    +1     
  Misses        208      208           
Flag Coverage Δ
unittests 93.41% <75.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/qrules/transition.py 87.85% <75.00%> (+0.02%) ⬆️

@redeboer redeboer merged commit 1f38b20 into main Sep 24, 2021
@redeboer redeboer deleted the custom-topology branch September 24, 2021 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📝 Docs Improvements or additions to documentation ✨ Feature New feature added to the package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Illustrate how to feed custom topologies
1 participant