Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DX: remove python.analysis.typeCheckingMode setting #399

Merged
merged 1 commit into from
Oct 4, 2024
Merged

DX: remove python.analysis.typeCheckingMode setting #399

merged 1 commit into from
Oct 4, 2024

Conversation

redeboer
Copy link
Member

@redeboer redeboer commented Oct 3, 2024

The python.analysis.typeCheckingMode setting in VS Code is not needed if there is a pyright conviguration in pyproject.toml.

@redeboer redeboer added the ⚙️ Enhancement Improvements and optimizations of existing features label Oct 3, 2024
@redeboer redeboer self-assigned this Oct 3, 2024
@redeboer redeboer enabled auto-merge (squash) October 3, 2024 18:48
@redeboer redeboer assigned shenvitor and redeboer and unassigned redeboer Oct 4, 2024
shenvitor
shenvitor approved these changes Oct 4, 2024
View reviewed changes
Copy link
Member

@shenvitor shenvitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very clear

@redeboer redeboer merged commit 5c1e820 into main Oct 4, 2024
20 checks passed
@redeboer redeboer deleted the typeCheckingMode branch October 4, 2024 09:52
@redeboer redeboer added this to the 0.4.2 milestone Oct 4, 2024
@redeboer redeboer modified the milestones: 0.5.0, 0.4.2 Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shenvitor shenvitor shenvitor approved these changes

Assignees

@shenvitor shenvitor

@redeboer redeboer

Labels
⚙️ Enhancement Improvements and optimizations of existing features
Projects
None yet
Milestone
0.4.2
Development

Successfully merging this pull request may close these issues.
2 participants
@redeboer @shenvitor