DX: recommend and configure VSCode mypy extension (#153)

* FIX: ignore `jsonschema` deprecation warning
* MAINT: autoupdate pre-commit hooks
* MAINT: remove `extract_extensions_test`

.gitpod.yml

@@ -22,6 +22,7 @@ vscode:
     - garaioag.garaio-vscode-unwanted-recommendations
     - github.vscode-github-actions
     - github.vscode-pull-request-github
+    - ms-python.mypy-type-checker
     - ms-python.python
     - ms-python.vscode-pylance
     - ms-vsliveshare.vsliveshare

.pre-commit-config.yaml

@@ -102,7 +102,7 @@ repos:
           - python
 
   - repo: https://github.com/pre-commit/mirrors-prettier
-    rev: v3.0.0-alpha.9-for-vscode
+    rev: v3.0.0
     hooks:
       - id: prettier
 
@@ -119,7 +119,7 @@ repos:
           - --py36-plus
 
   - repo: https://github.com/astral-sh/ruff-pre-commit
-    rev: v0.0.276
+    rev: v0.0.277
     hooks:
       - id: ruff
         args:

.vscode/extensions.json

@@ -9,6 +9,7 @@
     "garaioag.garaio-vscode-unwanted-recommendations",
     "github.vscode-github-actions",
     "github.vscode-pull-request-github",
+    "ms-python.mypy-type-checker",
     "ms-python.python",
     "ms-python.vscode-pylance",
     "ms-vsliveshare.vsliveshare",

.vscode/settings.json

@@ -38,14 +38,15 @@
   },
   "git.rebaseWhenSync": true,
   "github-actions.workflows.pinned.workflows": [".github/workflows/ci.yml"],
+  "mypy-type-checker.importStrategy": "fromEnvironment",
   "python.analysis.autoImportCompletions": false,
   "python.analysis.inlayHints.pytestParameters": true,
   "python.analysis.typeCheckingMode": "strict",
   "python.formatting.provider": "black",
   "python.linting.banditEnabled": false,
   "python.linting.enabled": true,
   "python.linting.flake8Enabled": false,
-  "python.linting.mypyEnabled": true,
+  "python.linting.mypyEnabled": false,
   "python.linting.pydocstyleEnabled": false,
   "python.linting.pylamaEnabled": false,
   "python.linting.pylintEnabled": false,

pyproject.toml

@@ -105,7 +105,10 @@ addopts = """
 --doctest-modules
 --durations=3
 """
-filterwarnings = ["error"]
+filterwarnings = [
+    "error",
+    "ignore: Importing ErrorTree directly from the jsonschema package is deprecated.*",
+]
 markers = ["slow: marks tests as slow (deselect with '-m \"not slow\"')"]
 testpaths = [
     "src",

src/repoma/check_dev_files/mypy.py

@@ -6,11 +6,23 @@
 
 from repoma.errors import PrecommitError
 from repoma.utilities import CONFIG_PATH
+from repoma.utilities.executor import Executor
 from repoma.utilities.pyproject import get_sub_table, load_pyproject, write_pyproject
+from repoma.utilities.vscode import add_extension_recommendation, set_setting
 
 
 def main() -> None:
-    _merge_mypy_into_pyproject()
+    executor = Executor()
+    executor(_merge_mypy_into_pyproject)
+    executor(add_extension_recommendation, "ms-python.mypy-type-checker")
+    executor(
+        set_setting,
+        {
+            "mypy-type-checker.importStrategy": "fromEnvironment",
+            "python.linting.mypyEnabled": False,
+        },
+    )
+    executor.finalize()
 
 
 def _merge_mypy_into_pyproject() -> None:

tests/check_dev_files/test_gitpod.py

@@ -3,32 +3,6 @@
 from repoma.check_dev_files.gitpod import _extract_extensions, _generate_gitpod_config
 
 
-def test_extract_extensions():
-    assert _extract_extensions() == [
-        # cspell:disable
-        "charliermarsh.ruff",
-        "christian-kohler.path-intellisense",
-        "davidanson.vscode-markdownlint",
-        "eamodio.gitlens",
-        "editorconfig.editorconfig",
-        "esbenp.prettier-vscode",
-        "garaioag.garaio-vscode-unwanted-recommendations",
-        "github.vscode-github-actions",
-        "github.vscode-pull-request-github",
-        "ms-python.python",
-        "ms-python.vscode-pylance",
-        "ms-vsliveshare.vsliveshare",
-        "redhat.vscode-yaml",
-        "ryanluker.vscode-coverage-gutters",
-        "stkb.rewrap",
-        "streetsidesoftware.code-spell-checker",
-        "tamasfe.even-better-toml",
-        "tyriar.sort-lines",
-        "yzhang.markdown-all-in-one",
-        # cspell:enable
-    ]
-
-
 @pytest.mark.parametrize("pin_dependencies", [False, True])
 def test_get_gitpod_content(pin_dependencies: bool):
     gitpod_content = _generate_gitpod_config(pin_dependencies)