Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: outsource to Lc2ppiKSemileptonicModelLHCb.jl #326

Merged
merged 30 commits into from
Dec 15, 2023

Conversation

redeboer
Copy link
Member

Closes #325

@redeboer redeboer added the 🔨 Maintenance Maintenance and upkeep improvements label Dec 13, 2023
@redeboer
Copy link
Member Author

161e5b5 updates Manifest.toml. Running the Pluto notebooks works without errors, but I did get the impression that some cells crash.

@redeboer
Copy link
Member Author

redeboer commented Dec 13, 2023

Next step is to recreate the environment under the julia/ directory with only Pluto.jl and Lc2ppiKSemileptonicModelLHCb.jl. I tried to do this as follows:

rm julia/*.toml
julia --project=julia

Then start the package manager and ran

(julia) pkg> add https://github.com/mmikhasenko/Lc2ppiKSemileptonicModelLHCb.jl

but got

    Updating git-repo `https://github.com/mmikhasenko/Lc2ppiKSemileptonicModelLHCb.jl`
   Resolving package versions...
ERROR: Unsatisfiable requirements detected for package ThreeBodyDecay [e6563dab]:
 ThreeBodyDecay [e6563dab] log:
 ├─ThreeBodyDecay [e6563dab] has no known versions!
 └─restricted to versions 0.6 by Lc2ppiKSemileptonicModelLHCb [2be14d12] — no versions left
   └─Lc2ppiKSemileptonicModelLHCb [2be14d12] log:
     ├─possible versions are: 0.1.0 or uninstalled
     └─Lc2ppiKSemileptonicModelLHCb [2be14d12] is fixed to version 0.1.0

@mmikhasenko
Copy link
Contributor

mmikhasenko commented Dec 13, 2023

seems to be julia issue with discovering unregistered packages, should be solved by installing TBD separately

]
add https://github.com/mmikhasenko/ThreeBodyDecay.jl
add https://github.com/mmikhasenko/Lc2ppiKSemileptonicModelLHCb.jl
# works afterwords
using Lc2ppiKSemileptonicModelLHCb
model = published_model("Default amplitude model")

@redeboer
Copy link
Member Author

@mmikhasenko please have a look at this log
https://github.com/ComPWA/polarimetry/actions/runs/7223081546/job/19681403799?pr=326
I don't get Julia's package dependency management. Shouldn't that dependency be pulled in from Lc2ppiKSemileptonicModelLHCb.jl?

@redeboer
Copy link
Member Author

Nvm the scripts just need to be updated 😅

@mmikhasenko
Copy link
Contributor

thanks for the julia test!
Works locally for me, let's see if CI works

@redeboer redeboer changed the title MAINT: outsource to Lc2ppiKSemileptonicModelLHCb.jl MAINT: outsource to Lc2ppiKSemileptonicModelLHCb.jl Dec 15, 2023
@redeboer
Copy link
Member Author

Cool thanks, seems to work now

@redeboer redeboer marked this pull request as ready for review December 15, 2023 15:12
@redeboer redeboer merged commit 274de39 into main Dec 15, 2023
19 checks passed
@redeboer redeboer deleted the extract-julia-package branch December 15, 2023 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨 Maintenance Maintenance and upkeep improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Separate Julia code to Lc2ppiKSemileptonicModelLHCb.jl
3 participants