Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: formulate pure SymPy amplitude model #13

Merged
merged 48 commits into from
Jul 12, 2024
Merged

DOC: formulate pure SymPy amplitude model #13

merged 48 commits into from
Jul 12, 2024

Conversation

shenvitor
Copy link
Member

@shenvitor shenvitor commented May 24, 2024

Formulate the model from the PWA101 tutorial (ComPWA/compwa.github.io#217, see TR-033) with SymPy. This issue only formulates the model and does some simple visualizations. After #36, the model can be visualized over phase space.

Tip

Merged already, see website here

Tip

See temporary preview here.

@shenvitor shenvitor self-assigned this May 24, 2024
@shenvitor shenvitor marked this pull request as draft May 24, 2024 16:57
@shenvitor shenvitor requested a review from redeboer June 7, 2024 13:15
@shenvitor shenvitor added the 📝 Docs Improvements or additions to documentation label Jun 7, 2024
@shenvitor
Copy link
Member Author

The idea now is to split this branch to one more branch because one for $\eta \pi p$ and the other is $\Lambda K^+ \pi^0$

@shenvitor shenvitor marked this pull request as ready for review July 9, 2024 14:06
@shenvitor
Copy link
Member Author

Dear @redeboer
This PR is now ready for re-review and merge

@redeboer redeboer changed the title DOC: form amplitude models in symbolic expression for PWA101 channel DOC: formulate PWA101 amplitude models symbolically Jul 9, 2024
@redeboer redeboer changed the title DOC: formulate PWA101 amplitude models symbolically DOC: formulate PWA101 model symbolically Jul 9, 2024
@redeboer redeboer assigned redeboer and unassigned shenvitor Jul 9, 2024
@redeboer redeboer changed the title DOC: formulate PWA101 model symbolically DOC: formulate pure SymPy amplitude model Jul 11, 2024
@shenvitor shenvitor enabled auto-merge (squash) July 11, 2024 09:48
Comment on lines +2 to +5
concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: |-
${{ github.ref != format('refs/heads/{0}', github.event.repository.default_branch) }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shenvitor I smuggled in this DX improvement: it aborts CI if additional commits are pushed, in order to save CI time 🌍

Copy link
Member

@redeboer redeboer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Großartig 🙌

@shenvitor shenvitor merged commit 40f69e5 into main Jul 12, 2024
4 checks passed
@shenvitor shenvitor deleted the symbolic branch July 12, 2024 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📝 Docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants