Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEAT: parametrize l in spherical harmonics #100

Merged
merged 17 commits into from
Sep 2, 2024
Merged

FEAT: parametrize l in spherical harmonics #100

merged 17 commits into from
Sep 2, 2024

Conversation

shenvitor
Copy link
Member

@shenvitor shenvitor commented Aug 27, 2024 •
edited
Loading

@shenvitor
initial commit
ea673b7 
l intslider
@shenvitor shenvitor added ⚙️ Enhancement Improvements and optimizations of existing features ✨ Feature New feature added to the package labels Aug 27, 2024
@shenvitor shenvitor requested a review from a team August 27, 2024 13:01
@shenvitor shenvitor self-assigned this Aug 27, 2024
@shenvitor shenvitor changed the title initial commit FEAT: make l in the Ylm changeable as a slider Aug 27, 2024
@redeboer redeboer marked this pull request as draft August 27, 2024 16:08
@redeboer redeboer changed the title FEAT: make l in the Ylm changeable as a slider FEAT: parametrize angular momentum in spherical harmonics Sep 2, 2024
@redeboer redeboer changed the title FEAT: parametrize angular momentum in spherical harmonics FEAT: parametrize l in spherical harmonics Sep 2, 2024
@redeboer redeboer marked this pull request as ready for review September 2, 2024 07:44
@redeboer
Copy link
Member

redeboer commented Sep 2, 2024 •
edited
Loading

@shenvitor there were a few things that could be improved. Have a look at f0d191c...dca7c42, particularly dca7c42. There was no need to collect the l sliders in a defaultdict (we do that only because of the tabs for each subsystem).

@shenvitor shenvitor merged commit a17e322 into main Sep 2, 2024
6 checks passed
@shenvitor shenvitor deleted the Ylm-sliders branch September 2, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@redeboer redeboer redeboer approved these changes

Assignees

@shenvitor shenvitor

Labels
⚙️ Enhancement Improvements and optimizations of existing features ✨ Feature New feature added to the package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make l in the Ylm changeable as a slider
2 participants
@shenvitor @redeboer