feat: zombie connection check #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lcsmuller
reviewed
Mar 21, 2024
This commit adds the check that verifies if the connection is dead, AKA zombie. Without this, once internet was unavailable for a certain time, Discord would stop responding to the heartbeats and wouldn't send any events, causing to the bot be offline, while the process would be still alive.
ThePedroo
force-pushed
the
feat/zombie-check
branch
from
5a83cbe
to
bc83587
Compare
lcsmuller
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notice
to test it before making changes to Concord.
What?
This PR introduces checks that ensures that the previous heartbeat was responded.
Why?
This avoids keeping a zombie connection, where the connection is over, however the client (Concord) is unaware of that for some reason. Heartbeats are meant for this, and should be used as it.
How?
This introduces a
hbeat_answeredfield, that defines whether or not the previous heartbeat was answered/responded.Testing?
Basic testing was done. However better testing should be done, and the code should be reviewed as well.
Anything Else?
While I believe it's important this PR, the reason for a lot of times Concord be unaware of closes may be to cws. I'll investigate further.