Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[crmsh-4.5] Fix: bootstrap: check is_nologin more robustly (bsc#1228251) #1557

Merged
merged 1 commit into from
Sep 20, 2024
Merged

[crmsh-4.5] Fix: bootstrap: check is_nologin more robustly (bsc#1228251) #1557

merged 1 commit into from
Sep 20, 2024

Conversation

nicholasyang2022
Copy link
Collaborator

@nicholasyang2022 nicholasyang2022 commented Sep 20, 2024 •
edited
Loading

@codecov Codecov
Copy link

codecov bot commented Sep 20, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.76%. Comparing base (907f6fa) to head (80d011e).
Report is 3 commits behind head on crmsh-4.5.

Additional details and impacted files
Flag Coverage Δ
integration 51.82% <100.00%> (-0.01%) ⬇️
unit 47.47% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
crmsh/bootstrap.py 81.71% <100.00%> (-0.07%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nicholasyang2022 nicholasyang2022 marked this pull request as ready for review September 20, 2024 05:18
@liangxin1300 liangxin1300 merged commit 16b5eae into ClusterLabs:crmsh-4.5 Sep 20, 2024
30 checks passed
@nicholasyang2022 nicholasyang2022 deleted the bsc_1228251_20240911_4.5 branch September 20, 2024 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liangxin1300 liangxin1300 liangxin1300 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicholasyang2022 @liangxin1300