Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uncomment normal addition #10

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Uncomment normal addition #10

wants to merge 2 commits into from

Conversation

ababo
Copy link

@ababo ababo commented Nov 7, 2021

No description provided.

@dgirardeau
Copy link
Member

Well, the fact is that repository is for CloudCompare only, and in the Poisson Reconstruction plugin of CloudCompare, we don't use the output normals... (they are automatically recomputed at the end of the process).

Is the intent to give the choice to the user to use these normals instead of re-computing them?

@ababo
Copy link
Author

ababo commented Nov 7, 2021

It seems that this repo is the best candidate for Poisson library dependency to be used in other projects. I think it might be useful for the community to have normal output enabled.

@dgirardeau
Copy link
Member

Can you maybe add an option (boolean) to the PoissonReconLib::Parameters structure then to control that?

And default it to 'false' so that it doesn't impact CC?

@ababo
Copy link
Author

ababo commented Nov 7, 2021

I think you won't need to change anything in the dependent codebase, just keep the Mesh::addNormal() method implementation empty.

@dgirardeau
Copy link
Member

Which sadly is not the case in the current codebase ;)

@ababo
Copy link
Author

ababo commented Nov 7, 2021

Up to you, I have cloned the project and will use it (thank you for your work, it's really useful!).

@ababo ababo force-pushed the master branch 5 times, most recently from ab33210 to 2ed08a7 Compare December 7, 2021 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants