Added GetSize() const method for FixedStringType
#355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By using ColumnLowCardinalityT<ColumnFixedString>, you lose the ability to conveniently know the fixed size parameter of ColumnFixedString. Adding this method fixes this issue.
|
|
|
Hi @german3w1 ! Thank your contribution, could you please add some unit-test for this method? Nothing fancy, since the method itself is pretty straightforward. Otherwise it looks Ok |
|
I think three unit-tests are enough to prove the method works as expected :) |
|
The building script for Mac with ssl support enabled seems broken to me. Other checks were successful so I think it can be merged now |
|
|
|
@Enmk kind ping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By using ColumnLowCardinalityT, you lose the ability to conveniently know the fixed size parameter of ColumnFixedString. Adding this method fixes this issue.