-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better estimation for ColumnLowCardinality::Reserve and ColumnString::Reserve #346
Open
Enmk
wants to merge
11
commits into
master
Choose a base branch
from
lc_reserve_fix
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Commits on Nov 16, 2023
-
Better estimation for ColumnLowCardinality::Reserve and ColumnString:…
…:Reserve ColumnLowCardinality assumes that not all items are unique, hence dictionary column can be reserved for smaller capacity; ColumnString now allows to set average value size estimation in constructor or on existing instance. If estimation is close to real average value size, then memory is pre-allocations are close to optimum.
Configuration menu - View commit details
-
Copy full SHA for 90414cc - Browse repository at this point
Copy the full SHA 90414ccView commit details
Commits on Nov 21, 2023
-
type-safer ColumnString::EstimatedValueSize, better validation, more …
…tests - Added validation for ColumnString::EstimatedValueSize value in ColumnString - Minor refactoring of block allocation in ColumnString - Moved test code for ColumnString and ColumnLowCardinality to separate files, - Added more test cases
Configuration menu - View commit details
-
Copy full SHA for bd3e408 - Browse repository at this point
Copy the full SHA bd3e408View commit details
Commits on Feb 24, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 0f4293a - Browse repository at this point
Copy the full SHA 0f4293aView commit details
Commits on Feb 25, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 11604cf - Browse repository at this point
Copy the full SHA 11604cfView commit details
Commits on Feb 26, 2024
-
More precise estimation of column size for ColumnString
Andded PrettyPrintByteSize + some tests
Configuration menu - View commit details
-
Copy full SHA for c90cd8c - Browse repository at this point
Copy the full SHA c90cd8cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 57a426c - Browse repository at this point
Copy the full SHA 57a426cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 12f0399 - Browse repository at this point
Copy the full SHA 12f0399View commit details
Commits on Feb 28, 2024
-
Configuration menu - View commit details
-
Copy full SHA for a72ad04 - Browse repository at this point
Copy the full SHA a72ad04View commit details
Commits on Feb 29, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 6aa60bd - Browse repository at this point
Copy the full SHA 6aa60bdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8f9f96a - Browse repository at this point
Copy the full SHA 8f9f96aView commit details
Commits on Mar 1, 2024
-
Configuration menu - View commit details
-
Copy full SHA for a4bed2d - Browse repository at this point
Copy the full SHA a4bed2dView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.