Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue #335 by making at least one connection attempt #336

Merged
merged 3 commits into from
Sep 30, 2023

Conversation

Enmk
Copy link
Collaborator

@Enmk Enmk commented Sep 29, 2023

Due to setting ClientOptions.SetSendRetries(0), Client made no attempts to connect to a server, which resulted in uninitialized streams and hence the crash.

Closes: #335

@Enmk Enmk merged commit 68e592c into ClickHouse:master Sep 30, 2023
16 checks passed
@rtcote
Copy link
Contributor

rtcote commented Oct 10, 2023

@Enmk do you a rough idea of when this will be put into a versioned release? Thank you!

@Enmk
Copy link
Collaborator Author

Enmk commented Oct 12, 2023

@Enmk do you a rough idea of when this will be put into a versioned release? Thank you!

it is already in v2.5.1, released on 30th of September.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Segfault caused by outputstream being null.
2 participants