Default momentum advection for the HydrostaticFreeSurfaceModel
#3842
+32
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glwagner
reviewed
Oct 9, 2024
Comment on lines
56
to
58
| default_momentum_advection(grid) = CenteredSecondOrder() | ||
|
|
||
| default_momentum_advection(::OrthogonalSphericalShellGrid) = VectorInvariant() |
There was a problem hiding this comment.
Suggested change
| default_momentum_advection(grid) = CenteredSecondOrder() | |
| default_momentum_advection(::OrthogonalSphericalShellGrid) = VectorInvariant() | |
| default_momentum_advection(grid) = CenteredSecondOrder() | |
| default_momentum_advection(::OrthogonalSphericalShellGrid) = VectorInvariant() |
what's your thought on
default_momentum_advection(grid) = VectorInvariant()There was a problem hiding this comment.
It might be advantageous. So that the momentum equation is by default in the vector invariant form for the HydrostaticFreeSurfaceModel
There was a problem hiding this comment.
Default VectorInvariant for the hydrostatic model makes sense to me. And it's valid on all grids we support, also nice.
|
some doctest errors |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #3806