Single column grid update_state! is missing the update_model_field_time_series!
#3756
Conversation
|
Bonus, also the |
Good to have because it might be useful for testing and also, its definitely best if the single column mode is identical (except for performance) to 3D mode. |
| @@ -37,6 +39,62 @@ const CAVD = ConvectiveAdjustmentVerticalDiffusivity | |||
| @test all(sic_model.velocities.u.data[1, 1, :] .≈ per_model.velocities.u.data[1, 1, :]) | |||
| @test all(sic_model.velocities.v.data[1, 1, :] .≈ per_model.velocities.v.data[1, 1, :]) | |||
| @test all(sic_model.tracers.c.data[1, 1, :] .≈ per_model.tracers.c.data[1, 1, :]) | |||
|
|
|||
| @info "Testing forcing a single column grid model with a FieldTimeSeries..." | |||
There was a problem hiding this comment.
it looks like this tests both single column and periodic
There was a problem hiding this comment.
Another way to do this test would be to add a single column grid test alongside wherever update_model_field_time_series is already tested. That might be less test code / easier to maintain.
Co-authored-by: Gregory L. Wagner <[email protected]>
Co-authored-by: Gregory L. Wagner <[email protected]>
required to force the model with a field time series.
This PR adds
update_model_field_time_series!to theupdate_state!for single column grids and a test