Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#86dtu93ty - Include how to write nft contracts (NEP-11) to the docum… #1270

Merged
merged 2 commits into from
Jun 19, 2024

Conversation

jplippi
Copy link
Contributor

@jplippi jplippi commented Jun 19, 2024

Summary or solution description
Adds instructions on how to create a NEP-11 contract to the getting started documentation

@jplippi jplippi requested a review from meevee98 June 19, 2024 22:11
@melanke
Copy link
Contributor

melanke commented Jun 19, 2024

Comment on lines 140 to 148
For **non-divisible** NFT contracts, the following method is also required:
- `balanceOf` - Returns the total amount of NFTs of the specified account.
- `transfer` - Transfers tokens to a specified account.
- `ownerOf` - Returns the address of the owner of a specified NFT ID.

For **divisible** NFT contracts, the following methods are also required:
- `balanceOf` - Returns the amount of NFTs of the specified NFT ID for the specified account.
- `transfer` - Transfers tokens to from a specified account to another.
- `ownerOf` - Returns the addresses of all co-owners of a specified NFT ID.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the method names are the same for each case, it should need to explain before this that the signatures are different, not only what each method returns

Comment on lines 154 to 155
Here's a [full example](https://github.com/CityOfZion/neo3-boa/blob/development/boa3_test/examples/nep11_non_divisible.py) of a non-divisible token contract following the NEP-11 standard.
>Note: The example above is rather complete and contains more than just the basic implementation of a NEP-11 contract. Once again, be sure to check the [full documentation](https://docs.neo.org/docs/en-us/develop/write/nep11.html) on the NEP-11 standard to ensure the implementation is correct.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just saw that you pasted the direct link to development branch, can you change it to relative path, so when it's merged to staging and master it links to the respective versions?
Same for the nep17 example

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 91.201%. remained the same
when pulling 95f470e on CU-86dtu93ty
into 26ea444 on development.

@meevee98 meevee98 merged commit 555a83d into development Jun 19, 2024
1 of 3 checks passed
@meevee98 meevee98 deleted the CU-86dtu93ty branch June 19, 2024 22:39
@coveralls
Copy link
Collaborator

Coverage Status

coverage: 91.201%. remained the same
when pulling 0a6ece6 on CU-86dtu93ty
into 26ea444 on development.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants