Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: do not post process on VM exception in test_invoke #316

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

ixje
Copy link
Member

@ixje ixje commented Sep 27, 2024

If a test invoke ends in a VMFault state we should not attempt to post process the results as the result stack likely does not contain what is necessary. In such a case it will cause exceptions in unwrapping code that can be confusing. This change ensures that the raw RPC results are returned on fault.

@ixje ixje merged commit 013d92c into master Sep 27, 2024
11 checks passed
@ixje ixje deleted the testinvoke-exception branch September 27, 2024 12:17
@coveralls
Copy link

Coverage Status

coverage: 80.546%. remained the same
when pulling e3d03d1 on testinvoke-exception
into 55e582c on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants