Skip to content

Commit

Permalink
Remove deprecated "views" from live video event
Browse files Browse the repository at this point in the history
  • Loading branch information
Chocobozzz committed Jul 28, 2023
1 parent 982edf3 commit 257df4c
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 5 deletions.
4 changes: 2 additions & 2 deletions server/lib/peertube-socket.ts
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
import { Server as HTTPServer } from 'http'
import { Namespace, Server as SocketServer, Socket } from 'socket.io'
import { isIdValid } from '@server/helpers/custom-validators/misc'
import { Debounce } from '@server/helpers/debounce'
import { MVideo, MVideoImmutable } from '@server/types/models'
import { MRunner } from '@server/types/models/runners'
import { UserNotificationModelForApi } from '@server/types/models/user'
import { LiveVideoEventPayload, LiveVideoEventType } from '@shared/models'
import { logger } from '../helpers/logger'
import { authenticateRunnerSocket, authenticateSocket } from '../middlewares'
import { Debounce } from '@server/helpers/debounce'

class PeerTubeSocket {

Expand Down Expand Up @@ -98,7 +98,7 @@ class PeerTubeSocket {
}

sendVideoViewsUpdate (video: MVideoImmutable, numViewers: number) {
const data: LiveVideoEventPayload = { viewers: numViewers, views: numViewers }
const data: LiveVideoEventPayload = { viewers: numViewers }
const type: LiveVideoEventType = 'views-change'

logger.debug('Sending video live views update notification of %s.', video.url, { viewers: numViewers })
Expand Down
3 changes: 0 additions & 3 deletions shared/models/videos/live/live-video-event-payload.model.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,5 @@ import { VideoState } from '../video-state.enum'
export interface LiveVideoEventPayload {
state?: VideoState

// FIXME: deprecated in 4.0 in favour of viewers
views?: number

viewers?: number
}

0 comments on commit 257df4c

Please sign in to comment.