Fix crash with websocket tracker

Chocobozzz · Feb 9, 2018 · 1e9d7b6 · 1e9d7b6
1 parent 53ac144
commit 1e9d7b6
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/server.ts b/server.ts
@@ -104,19 +104,18 @@ const trackerServer = new TrackerServer({
 })
 
 trackerServer.on('error', function (err) {
-  logger.error(err)
+  logger.error('Error in websocket tracker.', err)
 })
 
 trackerServer.on('warning', function (err) {
-  logger.error(err)
+  logger.error('Warning in websocket tracker.', err)
 })
 
 const server = http.createServer(app)
 const wss = new WebSocketServer({ server: server, path: '/tracker/socket' })
 wss.on('connection', function (ws) {
   trackerServer.onWebSocketConnection(ws)
 })
-wss.on('error', err => logger.error('Error in websocket server.', err))
 
 const onHttpRequest = trackerServer.onHttpRequest.bind(trackerServer)
 app.get('/tracker/announce', (req, res) => onHttpRequest(req, res, { action: 'announce' }))

diff --git a/server/helpers/logger.ts b/server/helpers/logger.ts
@@ -26,12 +26,12 @@ const loggerFormat = winston.format.printf((info) => {
   if (additionalInfos === '{}') additionalInfos = ''
   else additionalInfos = ' ' + additionalInfos
 
-  if (info.message.stack !== undefined) info.message = info.message.stack
+  if (info.message && info.message.stack !== undefined) info.message = info.message.stack
   return `[${info.label}] ${info.timestamp} ${info.level}: ${info.message}${additionalInfos}`
 })
 
 const timestampFormatter = winston.format.timestamp({
-  format: 'YYYY-MM-DD hh:mm:ss.SSS'
+  format: 'YYYY-MM-dd HH:mm:ss.SSS'
 })
 const labelFormatter = winston.format.label({
   label