The int unpacker seems to be solid

ChillerDragon · Aug 23, 2024 · 10c10c2 · 10c10c2
1 parent 1255498
commit 10c10c2
Showing 1 changed file with 22 additions and 5 deletions.
diff --git a/tests/unpacker_basic_ints_test.asm b/tests/unpacker_basic_ints_test.asm
@@ -14,18 +14,14 @@ _test_one_byte_ints:
     assert_eax_eq 2, __LINE__
 
 _test_negative_multi_byte:
-    call print_newline ; todo: remove
-
     mov byte [generic_buffer_128 + 0], 0xff
     mov byte [generic_buffer_128 + 1], 0x01
     unpacker_reset generic_buffer_128, 2
 
     call get_int
     assert_eax_eq -128, __LINE__
 
-_test_positive_three_byte:
-    call print_newline ; todo: remove
-
+_test_negative_three_byte:
     mov byte [generic_buffer_128 + 0], 0xff
     mov byte [generic_buffer_128 + 1], 0xff
     mov byte [generic_buffer_128 + 2], 0x01
@@ -34,5 +30,26 @@ _test_positive_three_byte:
     call get_int
     assert_eax_eq -16384, __LINE__
 
+_test_positive_three_byte:
+    mov byte [generic_buffer_128 + 0], 0x80
+    mov byte [generic_buffer_128 + 1], 0xff
+    mov byte [generic_buffer_128 + 2], 0x01
+    unpacker_reset generic_buffer_128, 3
+
+    call get_int
+    assert_eax_eq 16320, __LINE__
+
+_test_positive_three_byte_plus_one_byte:
+    mov byte [generic_buffer_128 + 0], 0x80
+    mov byte [generic_buffer_128 + 1], 0xff
+    mov byte [generic_buffer_128 + 2], 0x01
+    mov byte [generic_buffer_128 + 3], 0x06
+    unpacker_reset generic_buffer_128, 4
+
+    call get_int
+    assert_eax_eq 16320, __LINE__
+    call get_int
+    assert_eax_eq 6, __LINE__
+
     exit 0