October 1 package updates #12226
October 1 package updates #12226
Conversation
|
Thank you for the pull request, @ggetz! ✅ We can confirm we have a CLA on file for you. |
|
@lukemckinstry Could you please do a review? CI and running end-to-end tests locally should thoroughly cover these updates. |
|
the following snapshots appeared off (see filenames to tie back to test)
Made a separate issue for this one as discussed #12227
|
|
one more to check
|
|
Thanks @lukemckinstry! For a bit of context, the
That should be correct, we hide the background in those model tests.
I'm not able to reproduce at all. I'm pretty sure this is unrelated to this PR, as per #12227.
This is fine, see the Sandcastle example
This is fine, see the Sandcastle example
Expected. This one doesn't do much without a local GEE server set up.
This is fine, see the Sandcastle example. The top-down view doesn't look like much.
This is fine, see the Sandcastle example. The top-down view doesn't look like much. |
|
thanks for the responses/explanations of the screenshots @ggetz |
Description
We can get rid of
sinonentirely now, as Playwright finally supports manual system time control 🎉Any existing sinon functionality has been ported to use Playwright's
ClockAPI.Otherwise, these are routine package updates.
Testing plan
test-e2e-updatelocally and ensure appropriate screenshots are generated.Author checklist
CONTRIBUTORS.mdI have updatedCHANGES.mdwith a short summary of my changeI have added or updated unit tests to ensure consistent code coverageI have updated the inline documentation, and included code examples where relevant