Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Drag and drop handler #287

Merged
merged 5 commits into from
Jul 11, 2023
Merged

Add Drag and drop handler #287

merged 5 commits into from
Jul 11, 2023

Conversation

L-Super
Copy link
Member

@L-Super L-Super commented Jul 10, 2023

No description provided.

@tishion
Copy link
Member

tishion commented Jul 11, 2023

@L-Super 多谢你的PR,我看了下应该只有两个问题

  1. Core的PR我已经合并了,所以你可以更新一下这个PR,把Core的submodule更新到你提交的那个版本
  2. 代码格式化似乎不符合仓库里面的clang-format文件的定义,你可能需要配置一下你本地的clang-format工具,然后格式化一下修改过的代码

其他就没有问题了,感谢!

@L-Super
Copy link
Member Author

L-Super commented Jul 11, 2023

@L-Super 多谢你的PR,我看了下应该只有两个问题

  1. Core的PR我已经合并了,所以你可以更新一下这个PR,把Core的submodule更新到你提交的那个版本
  2. 代码格式化似乎不符合仓库里面的clang-format文件的定义,你可能需要配置一下你本地的clang-format工具,然后格式化一下修改过的代码

其他就没有问题了,感谢!

OK,代码规范的问题,应该是vs code配置的保存自动格式化未按照clang-format文件进行

@L-Super
Copy link
Member Author

L-Super commented Jul 11, 2023

@L-Super 多谢你的PR,我看了下应该只有两个问题

  1. Core的PR我已经合并了,所以你可以更新一下这个PR,把Core的submodule更新到你提交的那个版本
  2. 代码格式化似乎不符合仓库里面的clang-format文件的定义,你可能需要配置一下你本地的clang-format工具,然后格式化一下修改过的代码

其他就没有问题了,感谢!

我使用了VS Code和Clion分别进行代码格式化,似乎是正确的。我又尝试clang-format工具进行格式化:

 C:\Users\LMR\.vscode\extensions\ms-vscode.cpptools-1.16.3-win32-x64\LLVM\bin\clang-format.exe -style=file -i .\include\QCefView.h

结果一致,代码规范应该没问题

@tishion tishion merged commit 87ac1cd into CefView:main Jul 11, 2023
3 checks passed
@L-Super L-Super deleted the dragHandler branch July 19, 2023 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants