122-part-2-use-yaml-for-pattern-pages #143
Conversation
File for public paths and settings
Push dist folder to aws reading from ENV vars
All of these have moved into storefront-static. https://github.com/CasperSleep/storefront-static/pull/2
Remove storefront-static pages
temporarily sets favicon to casper C
Add favicon and gulp tasks for image processing
Remove svg4everybody
Update breadcrumbs demo to match new styles
Add colors usage documentation
Add new icons
Add footer breadcrumbs example
Also make a new npm shrinkwrap
|
^ I had the same issue that @josephco mentioned. I think it was complaining that |
content/popovers.yml
Outdated
| <span class="popover-container js-popover-container"> | ||
| <span class="popover-toggle js-popover-toggle">?</span> | ||
| <span class="popover js-popover is-invisible" data-position="right" aria-expanded="false">Density refers to the amount of material per cubic foot. High-density materials are more durable.</span> | ||
| </span> |
There was a problem hiding this comment.
A general thought - is there a way to pull the macro in, instead of duplicating the HTML here? We'll get out of sync quickly if the macro changes.
There was a problem hiding this comment.
@stewartyu Yes! We really like to have everything auto-generated. Looking at our yaml files, I feel like the macro and html ideally should render by just specifying a path to a template.
Tackling that was outside the scope of this PR where I just wanted to move content over to YAML. Moving content over to yaml also helped to expose some other improvements/ways we can simplify generation of pages.
There was a problem hiding this comment.
Awesome! I'm cool with putting that as a todo for later.
It's now a dependency of nightshade-core
Update typography font bundle
* Set page title and description with data obj if available - Add indentation for readbility * Remove page title from nightshade_layout - Inherits from parent template * Integrate data object. Allows tpls to run of yaml * Add yaml content files for all the patterns - The content in the files is temporary and will be expanded in subsequent PRs * Ignore content_api.json * Add tasks to use yaml as content data storage - Add gulp data task to convert yaml to json - Ammend gulp compile task to use json file as data for templates * Run gulp data as part of default task - For better diffs, write each item in array on new line * Recompile and reload browser when yaml content changes - Add cb to tasks to ensure dependencies execute correctly * Remove page title from pattern_layout * Update key names to avoid regression - Will move data object into yaml file in subsequent PR * [Fixup] Use correct key for backgrounds page data * Update key for homepage content for more clarity * Regenerate shrinkwrap with depedencies only
misscs
force-pushed
the
122-use-yaml-for-pattern-pages
branch
2 times, most recently
from
68eefb4
to
672f6ed
Compare
Remove margin top fix now handled in core
|
@stewartyu / @josephco I am not able to reproduce the error. I rebased this PR and addressed an error I was getting on Popovers/Tooltip pages. Can I get one more sanity check? Want to make sure I'm not missing the issue you both reported. Thanks! |
Update to nightshade core 2.5.1
|
@misscs No longer getting errors on running Gulp Not sure if this is known/expected, but the Code Example section with Macro and HTML toggles (and params below) is missing on the pattern page JS import paths may need cleaning to remove /src/ such as the Gallery page |
misscs
force-pushed
the
122-use-yaml-for-pattern-pages
branch
from
ac23498
to
f798407
Compare
- Change from data object to yaml - Remove some of the extra objects and arrays - Tmp move tech notes into a markdown file Moving content into yaml was a great exercise that left me wondering how we can simplify pattern creation and move to a very living/automated design system that reads from files (following name guideliens) and file comment blocks. Started some ideas/questions here to discuss with folks on Monday: https://www.evernote.com/l/ACQbqm00njxNwYJFo-3uQ8gm2_B1iVdivzA
Need to map this file so that Toggler works.
misscs
force-pushed
the
122-use-yaml-for-pattern-pages
branch
from
f798407
to
c606ce9
Compare
- Gallery - Backgrounds
| transpiler: "plugin-babel", | ||
| map: { | ||
| "feature.js": "github:viljamis/[email protected]" | ||
| } |
There was a problem hiding this comment.
I kind of liked the import feature from 'viljamis/feature.js path; it gives me some context around where the package is coming from.
|
@misscs Some remaining items:
|
Closes #122
Todo
Test
rm -rf distfolder to start from clean slategulpnightshade.rocks.