-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement source_col param in Isolines service #1326
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A minor
source_columns = source_manager.get_column_names() | ||
source_has_id = 'cartodb_id' in source_columns | ||
if source_col is None: | ||
source_col = CARTO_INDEX_KEY |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this is the default value, we could set it in the method signature and avoid this conditional.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't want to add this to the header because of the documentation (reference). The index is set as cartodb_id when there is no cartodb_id column in the dataframe, but this is something I want to keep internally. Does it make sense to you?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, makes sense then.
source_columns = source_manager.get_column_names() | ||
source_has_id = 'cartodb_id' in source_columns | ||
if source_col is None: | ||
source_col = CARTO_INDEX_KEY | ||
|
||
iso_function = '_cdb_{function}_exception_safe'.format(function=function) | ||
# TODO: use **options argument? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Closes #1303.
NOTE: DS tests are only e2e. There is a task to refactor them into unit tests: #1323.