Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isRemoteCalculationSupported: remove backwards compatbility check for spatial indices #917

Merged

Conversation

zbigg
Copy link
Contributor

@zbigg zbigg commented Oct 2, 2024

Description

Shortcut: https://app.shortcut.com/cartoteam/story/443888/katopody-llc-h3-widgets-not-filtering-properly

isRemoteCalculationSupported: remove backwards compatbility check for spatial indices

Type of change

  • Fix

Acceptance

Covered by unit-test

Basic checklist

  • Good PR name
  • Shortcut link
  • Changelog entry
  • Just one issue per PR
  • GitHub labels
  • Proper status & reviewers
  • Tests
  • Documentation

@zbigg zbigg added the bug Something isn't working label Oct 2, 2024
@zbigg zbigg requested a review from padawannn October 2, 2024 08:29
Copy link

github-actions bot commented Oct 2, 2024

Pull Request Test Coverage Report for Build 11142016706

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.04%) to 70.933%

Totals Coverage Status
Change from base Build 11123135584: -0.04%
Covered Lines: 2890
Relevant Lines: 3746

💛 - Coveralls

Copy link

github-actions bot commented Oct 2, 2024

Visit the preview URL for this PR (updated for commit 0a13512):

https://cartodb-fb-storybook-react-dev--pr917-bug-sc-443888-ka-l2lpg8bn.web.app

(expires Wed, 09 Oct 2024 10:24:01 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 517cc4d31d7e09cf277774e034094b67c301cd4c

Copy link
Contributor

@jmgaya jmgaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@zbigg zbigg force-pushed the bug/sc-443888/katopody-llc-h3-widgets-not-filtering-properly branch from e7102cd to ebec58f Compare October 2, 2024 09:53
@zbigg zbigg changed the title isRemoteCalculationSupported: dynamic aggregation of points to grid/h3 should be remote too isRemoteCalculationSupported: remove backwards compatbility check for spatial indices Oct 2, 2024
@zbigg zbigg force-pushed the bug/sc-443888/katopody-llc-h3-widgets-not-filtering-properly branch from d17132a to 0a13512 Compare October 2, 2024 10:17
@zbigg zbigg merged commit 40ea30a into master Oct 2, 2024
2 checks passed
@zbigg zbigg mentioned this pull request Oct 2, 2024
@zbigg zbigg deleted the bug/sc-443888/katopody-llc-h3-widgets-not-filtering-properly branch October 2, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants