Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated to Terraform Client 0.7 Updated docs #176

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Updated to Terraform Client 0.7 Updated docs #176

wants to merge 4 commits into from

Conversation

mattcoffey
Copy link

I encountered some issues while trying to run the demo so I'm sharing what I did to get up and running. PR: Capgemini/tf_tls#46 should be dealt with first and references to the mattcoffey fork in main.tf should be reverted back to Capgemini.

N.B.: Only tested with Digital Ocean

enxebre
enxebre reviewed Dec 15, 2016
View reviewed changes
inventory/inventory
@@ -1,8 +1,13 @@
[role=masters]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this here?

docs/getting-started-guides/aws/public.md
@@ -70,15 +70,26 @@ To install the role dependencies for Ansible execute:
cd /tmp/kubeform
ansible-galaxy install -r requirements.yml
```
Ensure that an ssh server is running on port 22 on your development machine.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this needed?

@enxebre
Copy link
Contributor

enxebre commented Dec 15, 2016

hey @mattcoffey thanks a lot for this, just dropped a few comments

enxebre
enxebre reviewed Dec 15, 2016
View reviewed changes
terraform/digitalocean/main.tf
@@ -47,7 +47,7 @@ resource "template_file" "etcd_discovery_url" {
}

module "ca" {
source = "github.com/Capgemini/tf_tls//ca"
Copy link
Contributor

@enxebre enxebre Dec 15, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you point the modules to github.com/tamsky/tf_tls/ for consistency which is already being used for aws and supports terraform >= 0.7.3 then we can move all back in one go to Cap

@mattcoffey
Copy link
Author

Thanks for the comments @enxebre The odd stuff in inventory/inventory and comment about local ssh server was related to making the ansible part work without having specified the TF_VAR_STATE_ROOT properly previously. When I realised that was the problem it became obvious that it wasn't necessary to copy the IPs from the output of terraform apply or have a local ssh server running.

@enxebre
Copy link
Contributor

enxebre commented Dec 19, 2016

Hey @mattcoffey as part of the upgrade for terraform 0.7 we'd need to update the the templates to be "Data Sources" analogous to https://github.com/Capgemini/kubeform/pull/172/files#diff-f7c82420f5bbe654c1ba49edd173dab3R14
and to be consistent with the list format as per https://github.com/Capgemini/kubeform/pull/172/files#diff-530c171466f13a11a8a7c715564dbc4bR85
I'll wait in case you wanna add support for that to this PR, otherwise I'll merge this anyway as It's an improvement over what we have now.
Thanks!

@mattcoffey
Copy link
Author

I'll update the templates when I get back from travel on the 27th. Thanks for the pointers Alberto!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enxebre enxebre enxebre left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattcoffey @enxebre