-
Notifications
You must be signed in to change notification settings - Fork 70
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge branch 'dev' into dependabot/npm_and_yarn/mongoose-5.13.20
- Loading branch information
Showing
4 changed files
with
205 additions
and
6 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
189 changes: 189 additions & 0 deletions
189
test/unit-tests/middleware/onlyOrgWithPartnerRoleTest.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,189 @@ | ||
| /* eslint-disable no-unused-expressions */ | ||
|
|
||
| const chai = require('chai') | ||
| const sinon = require('sinon') | ||
| const { faker } = require('@faker-js/faker') | ||
| const expect = chai.expect | ||
|
|
||
| const OrgRepository = require('../../../src/repositories/orgRepository.js') | ||
| const { onlyOrgWithPartnerRole } = require('../../../src/middleware/middleware.js') | ||
| const errors = require('../../../src/middleware/error.js') | ||
| const error = new errors.MiddlewareError() | ||
|
|
||
| const stubAdpOrg = { | ||
| short_name: 'adpOrg', | ||
| name: 'test_adp', | ||
| UUID: faker.datatype.uuid(), | ||
| authority: { | ||
| active_roles: [ | ||
| 'ADP' | ||
| ] | ||
| } | ||
| } | ||
|
|
||
| const stubCnaOrg = { | ||
| short_name: 'cnaOrg', | ||
| name: 'test_cna', | ||
| UUID: faker.datatype.uuid(), | ||
| authority: { | ||
| active_roles: [ | ||
| 'CNA' | ||
| ] | ||
| } | ||
| } | ||
|
|
||
| const stubBulkDownloadOrg = { | ||
| short_name: 'bdOrg', | ||
| name: 'test_bd', | ||
| UUID: faker.datatype.uuid(), | ||
| authority: { | ||
| active_roles: [ | ||
| 'BULK_DOWNLOAD' | ||
| ] | ||
| } | ||
| } | ||
|
|
||
| const stubOrgNoRole = { | ||
| short_name: 'NoRole', | ||
| name: 'test_org', | ||
| UUID: faker.datatype.uuid(), | ||
| authority: { | ||
| active_roles: [] | ||
| } | ||
| } | ||
|
|
||
| const stubSecretariat = { | ||
| short_name: 'secOrg', | ||
| name: 'test_sec', | ||
| UUID: faker.datatype.uuid(), | ||
| authority: { | ||
| active_roles: [ | ||
| 'SECRETARIAT' | ||
| ] | ||
| } | ||
| } | ||
|
|
||
| describe('Testing onlyOrgWithPartnerRole middleware', () => { | ||
| let status, json, res, next, getOrgRepository, orgRepo | ||
| beforeEach(() => { | ||
| status = sinon.stub() | ||
| json = sinon.spy() | ||
| res = { json, status } | ||
| next = sinon.spy() | ||
| status.returns(res) | ||
| orgRepo = new OrgRepository() | ||
| getOrgRepository = sinon.stub() | ||
| getOrgRepository.returns(orgRepo) | ||
| }) | ||
| context('Negative Tests', () => { | ||
| it('Should return 403 for users from orgs without a partner role ', async () => { | ||
| const req = { | ||
| ctx: { | ||
| org: stubBulkDownloadOrg.short_name, | ||
| uuid: stubBulkDownloadOrg.UUID, | ||
| repositories: { | ||
| getOrgRepository | ||
| } | ||
| } | ||
| } | ||
| const stub = sinon.stub(orgRepo, 'findOneByShortName').returns(stubBulkDownloadOrg) | ||
|
|
||
| await onlyOrgWithPartnerRole(req, res, next) | ||
| expect(stub.calledOnce).to.be.true | ||
| expect(status.calledOnce).to.be.true | ||
| expect(status.args[0][0]).to.equal(403) | ||
| expect(res.json.args[0][0].error).to.equal(error.orgHasNoPartnerRole().error) | ||
| }) | ||
| it('Should return 403 for users from orgs without a role ', async () => { | ||
| const req = { | ||
| ctx: { | ||
| org: stubOrgNoRole.short_name, | ||
| uuid: stubOrgNoRole.UUID, | ||
| repositories: { | ||
| getOrgRepository | ||
| } | ||
| } | ||
| } | ||
| const stub = sinon.stub(orgRepo, 'findOneByShortName').returns(stubOrgNoRole) | ||
|
|
||
| await onlyOrgWithPartnerRole(req, res, next) | ||
| expect(stub.calledOnce).to.be.true | ||
| expect(status.calledOnce).to.be.true | ||
| expect(status.args[0][0]).to.equal(403) | ||
| expect(res.json.args[0][0].error).to.equal(error.orgHasNoPartnerRole().error) | ||
| }) | ||
|
|
||
| it('Should return 404 if the requester org does not exist', async () => { | ||
| const req = { | ||
| ctx: { | ||
| org: stubCnaOrg.short_name, | ||
| uuid: stubCnaOrg.UUID, | ||
| repositories: { | ||
| getOrgRepository | ||
| } | ||
| } | ||
| } | ||
| const stub = sinon.stub(orgRepo, 'findOneByShortName').returns(null) | ||
|
|
||
| await onlyOrgWithPartnerRole(req, res, next) | ||
| expect(stub.calledOnce).to.be.true | ||
| expect(status.calledOnce).to.be.true | ||
| expect(status.args[0][0]).to.equal(404) | ||
| expect(res.json.args[0][0].error).to.equal(error.orgDoesNotExist(stubCnaOrg.short_name).error) | ||
| }) | ||
| }) | ||
|
|
||
| context('Positive Tests', () => { | ||
| it('Should allow orgs with ADP partner role through by calling next() ', async () => { | ||
| const req = { | ||
| ctx: { | ||
| org: stubAdpOrg.short_name, | ||
| uuid: stubAdpOrg.UUID, | ||
| repositories: { | ||
| getOrgRepository | ||
| } | ||
| } | ||
| } | ||
| const stub = sinon.stub(orgRepo, 'findOneByShortName').returns(stubAdpOrg) | ||
|
|
||
| await onlyOrgWithPartnerRole(req, res, next) | ||
| expect(stub.calledOnce).to.be.true | ||
| expect(status.calledOnce).to.be.false | ||
| expect(next.calledOnce).to.be.true | ||
| }) | ||
| it('Should allow orgs with CNA partner role through by calling next() ', async () => { | ||
| const req = { | ||
| ctx: { | ||
| org: stubCnaOrg.short_name, | ||
| uuid: stubCnaOrg.UUID, | ||
| repositories: { | ||
| getOrgRepository | ||
| } | ||
| } | ||
| } | ||
| const stub = sinon.stub(orgRepo, 'findOneByShortName').returns(stubCnaOrg) | ||
|
|
||
| await onlyOrgWithPartnerRole(req, res, next) | ||
| expect(stub.calledOnce).to.be.true | ||
| expect(status.calledOnce).to.be.false | ||
| expect(next.calledOnce).to.be.true | ||
| }) | ||
| it('Should allow orgs with Secretariat role through by calling next() ', async () => { | ||
| const req = { | ||
| ctx: { | ||
| org: stubSecretariat.short_name, | ||
| uuid: stubSecretariat.UUID, | ||
| repositories: { | ||
| getOrgRepository | ||
| } | ||
| } | ||
| } | ||
| const stub = sinon.stub(orgRepo, 'findOneByShortName').returns(stubSecretariat) | ||
|
|
||
| await onlyOrgWithPartnerRole(req, res, next) | ||
| expect(stub.calledOnce).to.be.true | ||
| expect(status.calledOnce).to.be.false | ||
| expect(next.calledOnce).to.be.true | ||
| }) | ||
| }) | ||
| }) |