Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HOMEWORK 1 #9

Closed
wants to merge 7 commits into from
Closed

HOMEWORK 1 #9

wants to merge 7 commits into from

Conversation

kjara03
Copy link

@kjara03 kjara03 commented Aug 4, 2024

What type of PR is this? (check all applicable)

  • ♻️ Refactor
  • ✨ Feature
  • 🐛 Bug Fix
  • 👷 Optimization
  • 📝 Documentation Update
  • 🔖 Release
  • 🚩 Other

Description

This PR [adds/removes/fixes/replaces] this [feature/bug/etc].

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help

Added to documentation?

  • 📜 readme
  • 📜 contributing.md
  • 📓 docs
  • 📕 storybook
  • 🙅 no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

@kjara03
Copy link
Author

kjara03 commented Aug 4, 2024

Homework 1

@@ -4,6 +4,7 @@
*/
function transformArrayToUpper(listOfStrings) {
return;
return listOfStrings.map(str => str.toUpperCase());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the return on line 6 and 20 are causing your test fails

@medgardo
Copy link
Member

@medgardo medgardo closed this Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants