Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added hw2 for pull request #20

Closed
wants to merge 3 commits into from
Closed

Conversation

davinsoman
Copy link

What type of PR is this? (check all applicable)

  • ♻️ Refactor
  • ✨ Feature
  • 🐛 Bug Fix
  • 👷 Optimization
  • 📝 Documentation Update
  • 🔖 Release
  • [ X] 🚩 Other

Description

This PR adds validation checks for usernames and passwords.

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings

Added tests?

  • [X ] 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help

Added to documentation?

  • 📜 readme
  • 📜 contributing.md
  • 📓 docs
  • 📕 storybook
  • [ X] 🙅 no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

davinsoman and others added 2 commits August 13, 2024 21:25
First iteration of uppercase and sum functions. Passes tests from test file
@davinsoman davinsoman changed the title hw1: Added username and password checks for hw1 Added hw2 for pull request Aug 14, 2024
@davinsoman
Copy link
Author

Added the pull request for hw2 but I am unsure if the commit is seen from the current pull request or needs to make a new pull request.

@medgardo
Copy link
Member

@medgardo medgardo closed this Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants