Home Work 2 done #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
medgardo
reviewed
Aug 29, 2024
Comment on lines
+28
to
+41
| let SpecialChars = /[!@#$%^&*.?]/; | ||
| let UpperLetter = /[a-z]/; | ||
| let LowerLetter = /[A-Z]/; | ||
| let Num = /[0-9]/; | ||
| if(password.length>9&&password.length<65){ | ||
| if(password.search(SpecialChars)!=-1){ | ||
| if(password.search(UpperLetter)!=-1 || password.search(LowerLetter)!=-1){ | ||
| if(password.search(Num)!=-1){ | ||
| return true; | ||
| } | ||
| } | ||
| } | ||
| } | ||
| return false; |
There was a problem hiding this comment.
This code is correct, but for clarity in more complex code, consider using if-statement guard clauses like in this example: https://github.com/CUNYTechPrep/js-summer-prep-2024/blob/main/session-01/validators.solution.js#L10-L16
|
✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
This PR [adds/removes/fixes/replaces] this [feature/bug/etc].
Related Tickets & Documents
Mobile & Desktop Screenshots/Recordings
Added tests?
Added to documentation?
[optional] Are there any post-deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?