Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add signals for Motion Management #785

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

erikbosch
Copy link
Collaborator

@erikbosch erikbosch commented Oct 15, 2024

This is a proposal to add a number of signals for vehicle motion management, for instance making sure that vehicle stability is maintained during braking and when turning. As this is somewhat complex area it is also proposed to add a page in documentation to describe possible usage.

I will invite subject matter experts to the VSS meetings October 22nd and 29th so that they can give background to the change and answer questions.

Signed-off-by: Erik Jaegervall <[email protected]>
@erikbosch erikbosch marked this pull request as ready for review October 15, 2024 11:52
@SebastianSchildt
Copy link
Collaborator

You mean invite them October? I assume not September NEXT year?

@erikbosch
Copy link
Collaborator Author

You mean invite them October? I assume not September NEXT year?

Oh dear, is it already October?

@SebastianSchildt
Copy link
Collaborator

I was wondering, with these "more specialized" VSS areas, should we give easy options (i.e. via overlay) to ONLY transform this branch, or maybe even formulate this as a self contained tree (and thus potential overlay).

Don't get me wrong, I think it is very cool to extend VSS in this direction, and instead of blocking this with another half year discussion, let's rather check and merge it. I am just thinking that the criteria for "generally useful" when deciding what to add later are different from the VehicleMotion Branch compared to the whole tree (or let's say infotainment), so maybe it is the time to have the moduels/profiles/composable stndnard model discussion again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants