-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ObstacleDetection instances, attributes and Adaptive CruiseControl #780
base: master
Are you sure you want to change the base?
Conversation
…d adding Adaptive to CruiseControl
description: Distance in meters to detected object | ||
|
||
ObstacleDetection.TimeGap: | ||
datatype: int32 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Has negative number a meaning, or would uint32 suffice?
Has this one and Distance
only significance if ObstacleDetection.IsWarning
is True, or what values should be used if there is no obstacle?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unsigned is fine but wanted decimal instead of rounding to full integer.
@@ -113,6 +124,9 @@ LaneDepartureDetection.IsError: | |||
# | |||
ObstacleDetection: | |||
type: branch | |||
instances: | |||
- ["Front", "Rear"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need the instances also for the existing signals like IsEnabled
, IsWarning
and so on? If not we could split to two branches, one called ObstacleDetection
(without instances) and one called Obstacles
(with instances)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Each ObstacleDetection sensor could throw a separate warning, be disabled independently etc,
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Previous conversation before considering instances approach
MoM:
|
Adaptive cruise control distance setting typically seen on the dashboard user interface as increments (eg 1-5) that may be either vehicle lengths or an incremental variable that also factors in vehicle speed for safe following distance. If the latter a setting of 1 may be 10 meters at 30km/h but 30 at 90 km/h. In that case it would be more important to note the user preferred an adaptive buffer of 1 that has no fixed length but fluctuates with speed. We ask the OEM and suppliers on the VSS call to give clarity to conventions in production wrt adaptive cruise control.
In adding instances to ObstacleDetected, we want to be able to support multiple leaf nodes as multiple obstacles can be detected concurrently. Here too we want input from OEM and suppliers on the multitude of obstacle detecting sensors in mainstream vehicles. We realize more advanced autonomous vehicles will have far more lidar/camera/other sensors detecting and tracking obstacles. Degrees with zero being directly in front would provide more flexibility but trying to keep it simple. We want to avoid Center in both Y and X axis and based on feedback will likely go with "Middle" or "-" for Y.
instances:
- ["Front", "-", "Rear"]
- ["Left", "Center", "Right"]
We also want ObjectType such as wildlife, pedestrian, bicycle, vehicle, etc but again hope someone in the community can direct us to an effort like Sensoris that should be leveraged instead of defining ourselves.