Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update on Mirror & Coding Guidelines #7

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ravurinaresh
Copy link

Decimal values are replaced with Hex values in Cabin_Climate_topics proto.
Same will applied to rest of the project. once its accepted.

Cabin_Climate_topics proto.

Same will applied to rest of the project. once its accepted.
 mirrors at the same time.

 This will reduce the number of rps calls to react on both mirriors.
@ravurinaresh ravurinaresh changed the title Decimal values are replaced with Hex values Update on Mirror & Coding Guidelines Mar 24, 2024
@ravurinaresh
Copy link
Author

Updated Climate for coding guidelines
Updated Mirror with additional services

@stevenhartley
Copy link
Collaborator

@ravurinaresh why (hex in lieu of decimal)?

@halimragab
Copy link
Collaborator

I had similar question.
Also which coding guideline being updated ?

@ravurinaresh
Copy link
Author

ravurinaresh commented Mar 25, 2024 via email

@halimragab
Copy link
Collaborator

Hi @ravurinaresh let us discuss in a call when we can and we can decide what to do with this PR

@ravurinaresh
Copy link
Author

ravurinaresh commented Apr 9, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants