Update containers and include CI test for container builds #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
August 8, 2023 14:00
These scripts are used to set up a working environment - primarily when creating a container with the working environment but might be useful also on a "native" setup. The installation script now inserts the pyenv init (set up path etc.) in ~/.bashrc. But in the install_python_version_in_pyenv.sh script we can set up PATH to the pyenv binary directly, before using it. Signed-off-by: Gunnar Andersson <gunnar_dev@[email protected]>
It seems that ==6.0 failed to compile wheel on the Alpine container for unknown reason. This compiles cleanly, so I suppose some bug was fixed. Signed-off-by: Gunnar Andersson <gunnar_dev@[email protected]>
It now works, uses pyenv to install a python version and paths are OK for launching ifexgen. Fixes were mostly in previous commit. Signed-off-by: Gunnar Andersson <gunnar_dev@[email protected]>
- Restructured Makefile to reduce duplication of code. - Add targets to run pytest inside containers - Fixes to Alpine container as well, so that it works... Signed-off-by: Gunnar Andersson <gunnar_dev@[email protected]>
(Use short names that will later work on build-badges in README) Updated also setup-python action - seems to remove some bugs. Signed-off-by: Gunnar Andersson <gunnar_dev@[email protected]>
According to another source, these are the required dependencies to build python from source via pyenv. Signed-off-by: Gunnar Andersson <gunnar_dev@[email protected]>
gunnarx
force-pushed
the
container_tests
branch
2 times, most recently
from
1d22b0b
to
fb4ec84
Compare
added 2 commits
August 15, 2023 15:07
Signed-off-by: Gunnar Andersson <gunnar_dev@[email protected]>
This is a wrapper that the user can invoke instead of ifexgen to execute the tool in the container installation instead of a local installation. The usage should be identical, hopefully. (It existed before but is now matching the updated container setup) EDIT: Add similar support for D-Bus generator Signed-off-by: Gunnar Andersson <gunnar_dev@[email protected]>
gunnarx
force-pushed
the
container_tests
branch
from
26a45c9
to
0a5bf89
Compare
gunnarx
changed the title
|
NOTE: The container builds/tests are a bit heavier on network/execution time, so they run on pull requests only, compared to the traditional unit test and docs generation that runs also on pushes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Significant update of the docker/container files.
Primary reason for the update:
(Some) detailed changes:
Why? -> The container setup enables:
NOTES:
It's good because it creates diversity in testing, but the original reason was to work around bugs with pyenv / compiling python from source on the alpine variant.