[DRAFT] dlt: Fix compilation warning #634
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
minminlittleshrimp
commented
May 20, 2024
•
minminlittleshrimp
commented
- Add checking for snprintf when parsing data from config file
- Multiple files logging: Refactor function to optimize memory handling with new log files creation
- log-storage: strncpy checking
minminlittleshrimp
force-pushed
the
warning_fix
branch
6 times, most recently
from
e41e1a2
to
1ef1132
Compare
minminlittleshrimp
changed the title
minminlittleshrimp
force-pushed
the
warning_fix
branch
2 times, most recently
from
b7fb30c
to
ea10901
Compare
Signed-off-by: mluu <[email protected]>
minminlittleshrimp
force-pushed
the
warning_fix
branch
from
ea10901
to
45ff7dd
Compare
| char* file_name = files_buffer->filename; | ||
| memset(file_name, 0, length * sizeof(char)); | ||
| char *f_ptr = files_buffer->filename; | ||
| memset(f_ptr, 0, sizeof(files_buffer->filename) * sizeof(char)); |
There was a problem hiding this comment.
sizeof() already returns the size bytes. No need for sizeof(char) here
| strncat(files_buffer->filename, MULTIPLE_FILES_FILENAME_INDEX_DELIM, size); | ||
|
|
||
| size = size - strlen(MULTIPLE_FILES_FILENAME_INDEX_DELIM); | ||
| strncat(files_buffer->filename, file_index, size); |
There was a problem hiding this comment.
snprintf("%s%s%s...", str1, str2,...") would be better readable here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.