-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version 1.0: North Atlantic Update - Tides, Curved Boundaries, Config, and More!😀🤯🥳 #193
base: main
Are you sure you want to change the base?
Conversation
…CESM when parsing
Override min depth
Changes to make compatible with CESM
having mask table and layout no longer required
Fix layout requirements
fix typo in find replace
Replace minimum layers with min depth
…nt num After talking with Ashley, the find_MOM6_orientation will likely be removed
The function names for rectangular and sinmple boundaries were changed because the tides are a kind of boundary function, the old names now give a warning and call the correct function. GFDL had rough horizontal subsetting for the tpxo dataset (probably for efficiency?), implemented in setup_tides_rectangular_boundaries.
Collapsed the *_tidal_dims functions into the encode_tides function in segment, and add citing documentation to the docstrings for now.
…l-mom6 into croc_with_req_changes
Various bathymetry improvements / bugfixes
Add angled grids to RMOM6
Update comment to reflect name change
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Hi @manishvenu T H A N K S ! This is a huge PR. Is there any chance we break it into a few smaller ones? Otherwise reviewing will be hard.
|
@@ -129,7 +129,7 @@ def test_quadrilateral_areas(lat, lon, true_area): | |||
], | |||
) | |||
def test_rectangular_hgrid(lat, lon): | |||
assert isinstance(rectangular_hgrid(lat, lon), xr.Dataset) | |||
assert isinstance(generate_rectangular_hgrid(lat, lon), xr.Dataset) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The args are reversed in the test compared to the method definition
Probably doesn't matter for this test, but it might create confusion to users/developers.
Yes it's a huge PR! We did have this broken down into smaller PRs on the CROCODILE fork, which we reviewed and merged one by one over the last couple of months. Unfortunately these PRs might not be useful for us to break up this big one any more, because we did need to do a lot of merging given that @manishvenu and I were working in parallel on several changes. It's still in draft state for now while we polish it (build on the Is there a way you suggest that we break up the PR? Since we did a huge overhaul of the entire codebase, it's kind of hard to separate some of the changes! |
…up_run_directory (#20) * Package type changes for CRR * Black Formatting * Change MOM Param * Change MOM_param to Work * black * Remvoe premade_run_dir_arg * Remove init * Black * Update MOM_param_test * Clean
* include DataReader class * within __getattr__ read data files * bug * update demo with plots * typo
OK, when is ready to review we can talk again? Huge PRs are harder to review though and take longer...
Each of the major features mentioned in the first comment sounds like could be a PR? Just a suggestion.. |
haha, sorry if I introduced this difficulty to devs |
…x __getattr__ bug (#24)
Authors: @ashjbarnes, @manishvenu
Description:
Ashley and I worked together to add a few features to RM6. While we get the changes ready to merge with the main COSIMA branch, please check out this draft with a list of the changes below.
Major Features:
Minor Features:
Breaking Changes (for backwards compatibility):
Documentation Changes (TBD):
Co-authored-by: @ashjbarnes