Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename stream info iss27 #31

Merged
merged 1 commit into from
Aug 29, 2024
Merged

Conversation

ezhilsabareesh8
Copy link
Contributor

This PR address issue #29 and #27, by renaming the stream info variable.

Copy link
Collaborator

@dougiesquire dougiesquire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ezhilsabareesh8. Looks good.

Have you tried generating new stream files using these changes and running one of the configs?

@ezhilsabareesh8
Copy link
Contributor Author

Have you tried generating new stream files using these changes and running one of the configs?

Yes I did

  <stream_info name="JRA55do.LICALVF">
    <taxmode>limit</taxmode>
  <stream_info name="JRA55do.FRIVER">
    <taxmode>limit</taxmode>

Same changes were applied to datm.streams.xml with stream name starts as JRA55do.

Copy link
Collaborator

@dougiesquire dougiesquire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great thanks!

@ezhilsabareesh8 ezhilsabareesh8 merged commit 1a1cd0a into main Aug 29, 2024
4 checks passed
@ezhilsabareesh8 ezhilsabareesh8 deleted the data_stream_xml_generation_iss208 branch August 29, 2024 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants