generalise support for cice filenames #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anton-seaice
commented
Aug 16, 2024
There was a problem hiding this comment.
Thanks @anton-seaice. I've left some comments regarding the assumption that the 28th day is considered complete.
| #if the 1st and the 28th of that month exists, then assume its a whole month and concatenate | ||
| if [ -f $f ] && [ -f ${f/-01.nc/-28.nc} ]; then | ||
| elif [ -f $f ] && [ -f ${f/-01.nc/-28.nc} ] ; then |
There was a problem hiding this comment.
What if the month is, e.g., March, which has 31 days, but the available files only go up to the 29th day? This would still be considered incomplete.
Co-authored-by: minghang.li <[email protected]>
Co-authored-by: minghang.li <[email protected]>
anton-seaice
commented
Aug 18, 2024
|
The tests pass on gadi and fail on the github runner ! |
|
I think this is ready to go @minghangli-uni . Thanks for your suggestion, it works good! |
minghangli-uni
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per COSIMA/access-om3#190 (comment) allow for support of more variety in filenames and don't overwrite existing files
Closes #21