Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WNMGDS-2973: Change body copy for cmsgov theme to Public Sans #3248

Closed
wants to merge 2 commits into from

Conversation

malloryiden
Copy link
Collaborator

@malloryiden malloryiden commented Sep 27, 2024

Summary

Follow up PR related to #3227.

Isolated only the body copy change for CMSgov.

How to test

  1. Confirm that Public Sans was added as a design token.
  2. Confirm that the body copy, link text, and button text are using Public Sans

Checklist

  • Prefixed the PR title with the Jira ticket number as [WNMGDS-####] Title or [NO-TICKET] if this is unticketed work.
  • Selected appropriate Type (only one) label for this PR, if it is a breaking change, label should only be Type: Breaking
  • Selected appropriate Impacts, multiple can be selected.
  • Selected appropriate release milestone

@malloryiden malloryiden added Type: Breaking This item causes a breaking change. Impacts: CMSgov Impacts the CMS.gov theme directly. Type: Added Indicates a new feature. and removed Type: Added Indicates a new feature. labels Sep 27, 2024
@malloryiden malloryiden marked this pull request as draft September 27, 2024 19:27
Copy link
Collaborator

@tamara-corbalt tamara-corbalt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@malloryiden I noticed there are some snapshot changes that seem unrelated to the PR. You'll probably need to resolve the conflicts with main and merge those changes into your branch. Let me know if you need any help!

@malloryiden malloryiden force-pushed the mal/wnmgds-2973-change-body-copy-cmsgov branch from 8d8a002 to dc78761 Compare September 27, 2024 19:51
#3246)

* Changed focus color from orchid to copper

* reverted other token changes

* Updated snapshots

* Updated snapshots again

* Ran yarn build:docs and reran snapshots

---------

Co-authored-by: Mallory Iden <[email protected]>
@malloryiden
Copy link
Collaborator Author

@malloryiden I noticed there are some snapshot changes that seem unrelated to the PR. You'll probably need to resolve the conflicts with main and merge those changes into your branch. Let me know if you need any help!

Thank you! Yes, I noticed that and moved this PR to draft so I could work through them. I ended up reverting two commits so I could pull down from main again before updating the snapshots again. I'll ping you on slack if I get stuck!

@malloryiden malloryiden marked this pull request as ready for review September 27, 2024 20:37
@malloryiden malloryiden marked this pull request as draft September 27, 2024 20:39
@malloryiden malloryiden force-pushed the mal/wnmgds-2973-change-body-copy-cmsgov branch from e082df2 to 837e3f1 Compare September 27, 2024 20:45
@malloryiden malloryiden deleted the mal/wnmgds-2973-change-body-copy-cmsgov branch September 27, 2024 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Impacts: CMSgov Impacts the CMS.gov theme directly. Type: Breaking This item causes a breaking change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants