BFD-3517: Duplicate GET Locust test suites with POST #2432
Conversation
MahiFentaye
requested review from
mjburling,
dondevun,
meliGuzman,
aschey-forpeople and
malessi
as code owners
|
@MahiFentaye Please use a little more verbosity with the PR template. |
BFD-3517_duplicate-POST-Locust-test-suites updating hashed to unhashed
MahiFentaye
force-pushed
the
BFD-3517_duplicate-POST-Locust-test-suites
branch
from
fde5885
to
7567282
Compare
|
@MahiFentaye I think this looks good. Have you tested it? |
|
yes, I have tested @dondevun |
mjburling
changed the title
| @tag("claim", "exclude-samsa") | ||
| @task | ||
| def get_claim_with_exclude_samsa(self): | ||
| self.__post("Claim/_search", "excludeSAMSA", True) |
There was a problem hiding this comment.
Looks like a typo (or propagated typo) here, too.
There was a problem hiding this comment.
It looks like that's actually an issue with the existing code lol. So we haven't been testing with excludeSAMHSA set properly at all... fun.
There was a problem hiding this comment.
Good catch. yes, this two excludeSAMHSA tests don't pass for both GET and POST. It was easily missed because it doesn't say a test failed either, I had to look at the log above and see their are errors related to it.
I do see issues with hitting both Claim and ClaimResponse endpoints even after correcting the excludeSAMHSA typo. I will start a thread
There was a problem hiding this comment.
This test files were old and didn't need a post version since they aren't being used anymore, The new test files are deleted now. Thanks to Austin!
|
I think we also need to update |
…that aren't used anymore adding the new regression post test suit ti app.py BFD-3517_duplicate-POST-Locust-test-suites removing added post tests that aren't used anymore adding the new regression post test suit ti app.py
MahiFentaye
force-pushed
the
BFD-3517_duplicate-POST-Locust-test-suites
branch
5 times, most recently
from
1667eb1
to
20d3b65
Compare
…ries add post high_volume_suite BFD-3517_duplicate-POST-Locust-test-suites remove unused test and queries add post high_volume_suite
MahiFentaye
force-pushed
the
BFD-3517_duplicate-POST-Locust-test-suites
branch
from
20d3b65
to
67b8de3
Compare
correcting name
JIRA Ticket:
BFD-3517
What Does This PR Do?
BFD-3517_duplicate POST Locust test suites
adds
post_by_urlmethod that takes abodyparameterwhen
bodyis present, it will make aPOSTrequest instead of aGETThere is a copy of each test suit to a new POST version
What Should Reviewers Watch For?
If you're reviewing this PR, please check for these things in particular:
What Security Implications Does This PR Have?
Please indicate if this PR does any of the following:
Adds any new software dependencies
Modifies any security controls
Adds new transmission or storage of data
Any other changes that could possibly affect security?
I have considered the above security implications as it relates to this PR. (If one or more of the above apply, it cannot be merged without the ISSO or team security engineer's (
@sb-benohe) approval.)Validation
Have you fully verified and tested these changes? Is the acceptance criteria met? Please provide reproducible testing instructions, code snippets, or screenshots as applicable.
This has been tested against test db
locust -f v2/regression_suite_post.py --users 10 --spawn-rate 10 --spawned-runtime 30s
locust -f v1/regression_suite_post.py --users 10 --spawn-rate 10 --spawned-runtime 30s
locust -f high_volume_suite_post.py --users 10 --spawn-rate 10 --spawned-runtime 30s